Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Feb 4, 2026

Summary

This PR runs tests without permission checks for origin pull requests - changes sent from a forked branch still require approval: #552

Preview

The checks of the example above error on forks:

Error: Integration tests from forked branches require maintainer approval.
Notice: Dispatch a test run at https://github.com/slackapi/slack-github-action/actions/workflows/integration.yml with ref 'pull/552/head'

🔗 https://github.com/slackapi/slack-github-action/actions/runs/21665028776/job/62458200754?pr=552#step:2:7

Requirements

@zimeg zimeg self-assigned this Feb 4, 2026
@zimeg zimeg requested a review from a team as a code owner February 4, 2026 18:27
@zimeg zimeg added tests github_actions Pull requests that update GitHub Actions code labels Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (62b67a3) to head (9c70ad8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   95.90%   97.44%   +1.54%     
==========================================
  Files          14       14              
  Lines        2686     2705      +19     
==========================================
+ Hits         2576     2636      +60     
+ Misses        110       69      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg
Copy link
Member Author

zimeg commented Feb 4, 2026

🗣️ note: The requests to run tests above are an artifact of our current setup when running workflows in the "staging" environment. I'll approve these now, but we might remove this check if these changes are alright!

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution 💯 I like the separation of concern between unit tests and integration tests🚀

No comment, just good work!

@zimeg
Copy link
Member Author

zimeg commented Feb 12, 2026

@WilliamBergamin Kind thanks 🤧 Let's merge this now to avoid changes as #554 #555 #556 #557!

@zimeg zimeg merged commit 79c7509 into main Feb 12, 2026
11 checks passed
@zimeg zimeg deleted the zimeg-test-pr-target branch February 12, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants